Add isdone(itr::ReadEachIterator, state...) #39662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents `isempty` and friends from advancing the iterator when they shouldn't. Note: `collect(readeach(io, T))` can throw an exception if `io` isn't a multiple of the right size. `isempty` will still return `false`, even if the next call to `iterate` will throw an exception. Similar to: JuliaLang#27412
|
This is part of a (hopefully short) series of PRs that fix |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
This prevents `isempty` and friends from advancing the iterator when they shouldn't. Note: `collect(readeach(io, T))` can throw an exception if `io` isn't a multiple of the right size. `isempty` will still return `false`, even if the next call to `iterate` will throw an exception. Similar to: JuliaLang#27412
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
This prevents `isempty` and friends from advancing the iterator when they shouldn't. Note: `collect(readeach(io, T))` can throw an exception if `io` isn't a multiple of the right size. `isempty` will still return `false`, even if the next call to `iterate` will throw an exception. Similar to: JuliaLang#27412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
isemptyand friends from advancing the iterator when they shouldn't.Note:
collect(readeach(io, T))can throw an exception ifioisn't a multiple of the right size.isemptywill still returnfalse, even if the next call toiteratewill throw an exception.Similar to: #27412