Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base.isdone(itr::EachLine) #39562

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Add Base.isdone(itr::EachLine) #39562

merged 1 commit into from
Feb 8, 2021

Conversation

cmcaine
Copy link
Contributor

@cmcaine cmcaine commented Feb 7, 2021

With this method, isempty won't consume values from the iterator (See #27412).

This is completely untested. I'm trusting the CI to pick up any problems.

If this works and is accepted then I can do another PR for some of the other stateful iterators in Base.

base/io.jl Outdated Show resolved Hide resolved
base/io.jl Outdated Show resolved Hide resolved
@simeonschaub simeonschaub added io Involving the I/O subsystem: libuv, read, write, etc. needs tests Unit tests are required for this change labels Feb 7, 2021
With this method, `isempty` won't consume values from the iterator (See JuliaLang#27412).
@cmcaine
Copy link
Contributor Author

cmcaine commented Feb 8, 2021

Now has tests.

@vtjnash vtjnash merged commit ede6486 into JuliaLang:master Feb 8, 2021
@cmcaine cmcaine deleted the patch-3 branch March 5, 2021 14:26
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
With this method, `isempty` won't consume values from the iterator (See JuliaLang#27412).
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
With this method, `isempty` won't consume values from the iterator (See JuliaLang#27412).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io Involving the I/O subsystem: libuv, read, write, etc. needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants