Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify which are is modified in mul/div. #24698

Closed
wants to merge 2 commits into from
Closed

Clarify which are is modified in mul/div. #24698

wants to merge 2 commits into from

Conversation

simonbyrne
Copy link
Contributor

My stab at addressing JuliaLang/LinearAlgebra.jl#338.

@ararslan ararslan added docs This change adds or pertains to documentation linear algebra Linear algebra labels Nov 22, 2017
@mschauer
Copy link
Contributor

While a legal identifier, mulA!2(...) looks to me much like an operation mulA ! 2, not like a function name.

@tkelman
Copy link
Contributor

tkelman commented Jan 3, 2018

Aside from picking exactly what the names should be, I think this is a much better direction than what's on master. Mutating a different argument is a different operation, these shouldn't share the same generic function name when their results (side effects) are dramatically different.

@JeffBezanson
Copy link
Member

This is orthogonal to the changes on master. The changes on master affect the transposing part, not the mutation part.

@tkelman
Copy link
Contributor

tkelman commented Jan 3, 2018

I'm aware. This is an improvement over both master and release-0.6, though it would need to be rebased for the now-different name on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants