Relax test tolerance for Float32 #24256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
added
linear algebra
stevengj
reviewed
Oct 22, 2017
test/linalg/dense.jl
Outdated
| @@ -553,7 +553,7 @@ end | |||
| @test coth(acoth(coth(A))) ≈ coth(A) | |||
|
|
|||
| # Definition of principal values (Aprahamian & Higham, 2016, pp. 4-5) | |||
| abstol = 1e-8 * norm(acosh(A)) | |||
| abstol = max(1e-8, eps(real(elty))) * norm(acosh(A)) | |||
There was a problem hiding this comment.
Probably sqrt(eps(real(elty))) * vecnorm(acosh(A)) would do the trick here. (sqrt(ε) is the default reltol for isapprox, and we normally do approximate comparisons with vecnorm for performance.)
There was a problem hiding this comment.
OK, that works too.
This fix a test failure on aarch64 due to a real part of half ulp.
yuyichao
force-pushed
the
yyc/arm/test-tol
branch
from
1e2562a to
dd6eefd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a test failure on aarch64 due to a real part of half ulp.