Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for base.WrappedException #24200

Merged
merged 6 commits into from
Nov 22, 2017

Conversation

booleanings
Copy link
Contributor

PR related to #24043

Tried to base it off the documentation guide and used DimensionMismatch exception doc as an example.

Could possibly add additional info about LoadError and InitError but don't think this will be necessary

@kshyatt kshyatt added the docs This change adds or pertains to documentation label Oct 18, 2017
base/boot.jl Outdated
"""
WrappedException([msg])

wrap arbitrary exceptions generically.
Copy link
Contributor

@mschauer mschauer Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal: Generic type for Exceptions wrapping another Exception, such as LoadError and InitError.
Those exceptions contain information about the the root cause of an exception. Subtypes define a field error containing the causingException.

@xorJane
Copy link
Contributor

xorJane commented Oct 23, 2017

Thanks for the PR!

I think CI is failing because boot.jl is a bit finnicky. I encountered the same issue in #22521. Moving the docstring to helpdb/Base.jl should fix the issue! (You can check that it does by rebuilding Julia locally after making the change.)

If you need any help, let me know here or on slack. 😄

taking doc for WrappedException out of boot.jl per @xorJane's suggestion.
@JeffBezanson
Copy link
Member

Looks like the new location for the doc string was left out of this somehow.

`InitError`. Those exceptions contain information about the the root cause of an
exception. Subtypes define a field `error` containing the causing `Exception`.
"""
WrappedException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Core.WrappedException and things will be alright :)

Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aidaekay! :)

@Sacha0 Sacha0 merged commit b18ff77 into JuliaLang:master Nov 22, 2017
@xorJane
Copy link
Contributor

xorJane commented Nov 22, 2017

👍

KristofferC pushed a commit that referenced this pull request Nov 23, 2017
add a docstring for WrappedException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants