-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for base.WrappedException #24200
Conversation
base/boot.jl
Outdated
""" | ||
WrappedException([msg]) | ||
|
||
wrap arbitrary exceptions generically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposal: Generic type for Exception
s wrapping another Exception
, such as LoadError
and InitError
.
Those exceptions contain information about the the root cause of an exception. Subtypes define a field error
containing the causingException
.
Thanks for the PR! I think CI is failing because If you need any help, let me know here or on slack. 😄 |
taking doc for WrappedException out of boot.jl per @xorJane's suggestion.
Looks like the new location for the doc string was left out of this somehow. |
base/docs/basedocs.jl
Outdated
`InitError`. Those exceptions contain information about the the root cause of an | ||
exception. Subtypes define a field `error` containing the causing `Exception`. | ||
""" | ||
WrappedException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be Core.WrappedException
and things will be alright :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aidaekay! :)
👍 |
add a docstring for WrappedException
PR related to #24043
Tried to base it off the documentation guide and used
DimensionMismatch
exception doc as an example.Could possibly add additional info about
LoadError
andInitError
but don't think this will be necessary