Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an invariance bug in limit_type_depth. part of #23786 #23800

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

JeffBezanson
Copy link
Member

This fixes the specific issue reported, but after this I get a SIGILL in the package's tests. Running just the last testset gives

broadcast! matching indices: Error During Test
  Got an exception of type MethodError outside of a @test
  MethodError: Base.Broadcast.promote_containertype(::Type{TypeSortedCollections.TypeSortedCollection}, ::Type{TypeSortedCollections.TypeSortedCollection}) is ambiguous. Candidates:
    promote_containertype(::Type{TypeSortedCollections.TypeSortedCollection}, _) in TypeSortedCollections at /home/jeff/.julia/v0.7/TypeSortedCollections/src/TypeSortedCollections.jl:199
    promote_containertype(_, ::Type{TypeSortedCollections.TypeSortedCollection}) in TypeSortedCollections at /home/jeff/.julia/v0.7/TypeSortedCollections/src/TypeSortedCollections.jl:200
    promote_containertype(::Type{T}, ::Type{T}) where T in Base.Broadcast at broadcast.jl:43
  Possible fix, define
    promote_containertype(::Type{TypeSortedCollections.TypeSortedCollection}, ::Type{TypeSortedCollections.TypeSortedCollection})

but with the full suite this turns into a SIGILL.

@JeffBezanson JeffBezanson added backport pending 0.6 bugfix This change fixes an existing bug compiler:inference Type inference labels Sep 20, 2017
@tkoolen
Copy link
Contributor

tkoolen commented Sep 21, 2017

Hmm, that last test set also results in a method ambiguity error on 0.6 when run in isolation (and rightly so; a mistake on my part!), but passes when run after some other tests.

@JeffBezanson JeffBezanson merged commit ff9fb48 into master Sep 21, 2017
@JeffBezanson JeffBezanson deleted the jb/fix23786 branch September 21, 2017 20:34
ararslan pushed a commit that referenced this pull request Nov 7, 2017
ararslan pushed a commit that referenced this pull request Nov 8, 2017
ararslan pushed a commit that referenced this pull request Nov 8, 2017
@ararslan
Copy link
Member

ararslan commented Nov 8, 2017

I suspect my backporting of this to release-0.6 is not fully correct. Could you take a look, @JeffBezanson? 4a8d3a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants