fix homedir error handling for 1020+ character usernames #22457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Funny how untested code paths are doomed to fail. |
or 250 characters for a certain broken OS
vtjnash
force-pushed
the
jn/homedir-error
branch
from
cccb78d to
8c1adc8
Compare
|
I don't think this test is hitting the formerly-buggy code path, it passes for me reliably on 0.6 which has the bug. |
|
dunno. it fails for me reliably on multiple machines with multiple versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported on discourse https://discourse.julialang.org/t/julia-0-6-add-remote-workers-error/4372