Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend definition of StridedReshapedArray #22429

Merged
merged 2 commits into from
Jun 29, 2017
Merged

Extend definition of StridedReshapedArray #22429

merged 2 commits into from
Jun 29, 2017

Conversation

mtfishman
Copy link
Contributor

Fixes #22411

@ararslan ararslan added the linear algebra Linear algebra label Jun 18, 2017
@ararslan ararslan requested a review from timholy June 18, 2017 19:49
@tkelman
Copy link
Contributor

tkelman commented Jun 18, 2017

Add a test for something that this fixes?

@ararslan
Copy link
Member

Not sure how one could test this, since it's just making sure that certain array types go through a different path in dispatch that improves performance, right?

@mtfishman
Copy link
Contributor Author

A test could be something like:

A = rand(5, 5)
@test typeof(reshape(view(A, :, :), size(A))) <: StridedArray

@ararslan
Copy link
Member

Okay great, if you'd be willing to add that as a test, that'd be awesome. In the meantime, the current test failures here are unrelated.

As an aside, rather than typeof(x) <: T, you can do x isa T (or isa(x, T) if you prefer).

@mtfishman
Copy link
Contributor Author

Also this should be backported to 0.5 and 0.6.

@StefanKarpinski
Copy link
Member

Definitely squash when merging.

@andreasnoack andreasnoack merged commit 92ff1bc into JuliaLang:master Jun 29, 2017
ararslan pushed a commit that referenced this pull request Sep 11, 2017
@mtfishman @ararslan
Extend definition of StridedReshapedArray (#22429)
6cad82f 
* Extend definition of StridedReshapedArray

* Add test

Ref #22429
(cherry picked from commit 92ff1bc)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
@mtfishman @ararslan
Extend definition of StridedReshapedArray (#22429)
7696710 
* Extend definition of StridedReshapedArray

* Add test

(cherry picked from commit 92ff1bc)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
@mtfishman @vtjnash
Extend definition of StridedReshapedArray (#22429)
6e75807 
* Extend definition of StridedReshapedArray

* Add test

(cherry picked from commit 92ff1bc)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
@mtfishman @ararslan
Extend definition of StridedReshapedArray (#22429)
34e485c 
* Extend definition of StridedReshapedArray

* Add test

(cherry picked from commit 92ff1bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timholy timholy timholy approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mtfishman @tkelman @ararslan @StefanKarpinski @timholy @andreasnoack