Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM patches for new GC rooting #22022

Merged
merged 1 commit into from
May 23, 2017
Merged

Add LLVM patches for new GC rooting #22022

merged 1 commit into from
May 23, 2017

Conversation

Keno
Copy link
Member

@Keno Keno commented May 22, 2017

This is split out from #21888, to get the requisite LLVM patches on master first to make sure that CI works properly on that branch.

@Keno Keno requested a review from vtjnash May 22, 2017 20:42
@maleadt
Copy link
Member

maleadt commented Jul 28, 2017

Can we backport this to 0.6 (cc @tkelman)? Fixes seem harmless enough, and apply cleanly on 3.9.
Running into this with CUDAnative, where I load from Ptr+AS (JuliaGPU/CUDAnative.jl#84).
Bisected the fix from llvm-master to D32593, by @Keno 🥇

If OK, I'll do some more testing of course.

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2017

already came up in #22582, should be okay, but could really use a test for something that it fixes

@maleadt
Copy link
Member

maleadt commented Jul 28, 2017

That should be easy for the sink case (based on #22582), but the SROA one depends on a ptr+as. Although we could just splice in some IR for that. I'll have a look and propose a backport with tests.

maleadt added a commit that referenced this pull request Jul 29, 2017
maleadt added a commit that referenced this pull request Jul 29, 2017
JeffBezanson added a commit that referenced this pull request Jul 31, 2017
maleadt added a commit to JuliaGPU/CUDAnative.jl that referenced this pull request Aug 2, 2017
maleadt added a commit to JuliaGPU/CUDAnative.jl that referenced this pull request Aug 2, 2017
ararslan pushed a commit that referenced this pull request Sep 11, 2017
Add LLVM patches for new GC rooting

Ref #22022
(cherry picked from commit 8d4db9c)
ararslan pushed a commit that referenced this pull request Sep 11, 2017
Add a test for #22582/#22022.

Ref #23021
(cherry picked from commit f210687)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
Ref #22022
(cherry picked from commit 915910c)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
Ref #23021
(cherry picked from commit e55b1db)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
Ref #22022
(cherry picked from commit 915910c)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
Ref #23021
(cherry picked from commit e55b1db)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
Ref #22022
(cherry picked from commit 915910c)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
Ref #23021
(cherry picked from commit e55b1db)
ararslan pushed a commit that referenced this pull request Sep 16, 2017
Ref #23021
(cherry picked from commit e55b1db)
ararslan pushed a commit that referenced this pull request Sep 18, 2017
Ref #23021
(cherry picked from commit e55b1db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants