-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove some links to Nullable and methods #19961
Conversation
I find it distracting that every word `Nullable` and every method associated is a link. The link should appear only the first time the new method is mentioned.
@mzaffalon could you add the link in the first paragraph of the Nullable types section? Here would probably be the appropriate place:
|
itself was missing, or the test failed. | ||
* Perform general operations on single or multiple [`Nullable`](@ref) | ||
* Perform general operations on single or multiple `Nullable` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the words or multiple
here; I believe they were left over from #19787.
|
||
[`broadcast`](@ref) can be thought of as a way to make existing operations work | ||
`broadcast` can be thought of as a way to make existing operations work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "multiple data" mention here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean "broadcast
can be thought of as a way to make existing operations work simultaneously and propagate nulls"? Can you please confirm the sentence has a meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "make existing operations work on Nullable arguments and propagate nulls"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TotalVerb can you please check whether the change is OK? Otherwise feel free to edit it.
comment about broadcast on `Nullable`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, only the first reference to something in a section (chapter, whatever is a reasonable unit of text) should be a link to the definition.
Can this PR be merged? |
Yep, thanks for the reminder |
I find it distracting that every word
Nullable
and every method associated is a link.The link should appear only the first time a new method is mentioned.