Show methods for Signatures and Commits #19951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
display and printing
simonbyrne
reviewed
Jan 9, 2017
| function Base.show(io::IO, c::GitCommit) | ||
| authstr = sprint(show, author(c)) | ||
| cmtrstr = sprint(show, committer(c)) | ||
| print(io, "Commit Author: $authstr\nCommitter: $cmtrstr\nMessage:\n$(message(c))") |
There was a problem hiding this comment.
Maybe print the hash as well?
kshyatt
force-pushed
the
ksh/showcommit
branch
from
69e0908 to
deb6a9b
Compare
simonbyrne
reviewed
Jan 10, 2017
| function Base.show(io::IO, c::GitCommit) | ||
| authstr = sprint(show, author(c)) | ||
| cmtrstr = sprint(show, committer(c)) | ||
| print(io, "Commit Author: $authstr\nCommitter: $cmtrstr\nSHA: $(Oid(c))\nMessage:\n$(message(c))") |
There was a problem hiding this comment.
Oid is now GitHash (#19878)
There was a problem hiding this comment.
Also, it would probably be useful to print the typename, both here and the other PRs.
Add `show` methods for `Signature` and `Commit`s in LibGit2. Display the time of the commit using Julia's built-in date handling.
kshyatt
force-pushed
the
ksh/showcommit
branch
from
deb6a9b to
be99ce9
Compare
|
Updated! |
simonbyrne
approved these changes
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
showmethods forSignatureandCommits in LibGit2.Display the time of the commit using Julia's built-in date handling.
Re: #19839