-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix @threadcall
argument passing.
#17823
Conversation
871c82c
to
9d80aa0
Compare
The requirement is basically #17573, do we have that documented already? |
@llvmcall
argument passing.@threadcall
argument passing.
Fixes #17819. Also document not being allowed to call back into Julia.
9d80aa0
to
1cbc8de
Compare
I've restarted the OSX build which seems to have failed for other reasons. If that passes, is this PR good to go? |
when you restart a travis build, please back up the log to a gist first. travis overwrites logs when you restart. |
What even is the point of these OS X builds? Can we merge this? |
@yuyichao: even though that's the underlying cause of this restriction, it doesn't hurt to mention in the docstring for |
Apologies, will do next time. |
Yeah, this should be good to go. I had restarted the OS X bot already (to no avail), but forgot to mention it. |
@StefanKarpinski I'm only asking |
when something persistently fails, look more into the reasons next time |
I did, and even though I should have spotted the
So I assumed the failure to be unrelated (as it often happens)... Will be more careful next time. |
Fixes #17819. Also document not being allowed to call back into Julia.