Fix #17675 (concatenations involving special matrices) and #17738 (concatenations involving sparse vectors) #17685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| symtridiagmat = SymTridiagonal(ones(N), ones(N-1)) | ||
| specialmats = (diagmat, bidiagmat, tridiagmat, symtridiagmat) | ||
| for specialmata in specialmats, specialmatb in specialmats | ||
| @test issparse(hcat(specialmata, specialmatb)) |
There was a problem hiding this comment.
why typeof everywhere but here?
There was a problem hiding this comment.
Derp during fixup is why. Fixed. Thanks!
Sacha0
force-pushed
the
specialcat
branch
2 times, most recently
from
dc82d11 to
b2523ae
Compare
|
With #17690 merged, I rebased and extended this PR to fix |
Sacha0
changed the title
|
Now addresses #17738 as well. Best! |
…pecial matrices, sparse matrices, or dense matrices/vectors yield sparse arrays.
…ious matrix and vector types consistently yield sparse arrays.
Sacha0
changed the title
|
Rebased for 0.6. Best! |
|
Thanks! |
|
This is a behavior change and probably not a candidate for backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request's first commit addresses JuliaLang/LinearAlgebra.jl#349 by making
hcat,vcat,hvcat, andcatyield sparse arrays when operating on combinations of special matrices with special matrices, sparse matrices, or dense matrices/vectors.This pull request's second commit addresses #17738 by making concatenations involving sparse matrices more consistently yield sparse arrays, concatenations involving both sparse vectors and special matrices included.
This pull request does not fix the behavior of combinations involving annotation/wrapper/view types such as
<:AbstractTriangular(see JuliaLang/LinearAlgebra.jl#350).Ref. #17660. Best! (Edits: Rewritten for PR scope expansion.)