Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix appveyor segfault from toolchain ABI incompatibilities #15285

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Fix appveyor segfault from toolchain ABI incompatibilities #15285

merged 1 commit into from
Feb 29, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Feb 29, 2016

using get_toolchain.sh script

New nightlies were built today for the first time in a while, yay, but something changed abi and made win64 appveyor segfault, boo. Trying to fix it.

@tkelman tkelman force-pushed the tk/appveyor branch 3 times, most recently from 81d0ea3 to 3762fc5 Compare February 29, 2016 03:59
@ViralBShah ViralBShah added the system:windows Affects only Windows label Feb 29, 2016
@tkelman
Copy link
Contributor Author

tkelman commented Feb 29, 2016

@vtjnash need your assistance on that win32 cmdlineargs failure (edit: was in https://ci.appveyor.com/project/StefanKarpinski/julia/build/1.0.13873/job/3pi4g4oi5d7xxj1y). it's segfaulting with -O3, not sure why.

@tkelman tkelman force-pushed the tk/appveyor branch 2 times, most recently from af523d1 to 83a64de Compare February 29, 2016 06:57
@tkelman
Copy link
Contributor Author

tkelman commented Feb 29, 2016

the segfault is in llvm::Value::setNameImpl(llvm::Twine const&) (), I wonder if this is the mingw gcc 5 miscompiling llvm issue

@tkelman
Copy link
Contributor Author

tkelman commented Feb 29, 2016

win32 was segfaulting in setNameImpl, win64 gives a better backtrace and a different location: https://gist.github.com/ce698e93fd2aa84b30fd

@tkelman
Do not copy gcc dlls from dist-extras in windows binary-dist
c1e565c 
Use versions from the build system rather than win-extras (which downloads
from opensuse)

Remove gcc dlls from downloaded nightly on appveyor
@tkelman tkelman changed the title Download opensuse toolchain on appveyor Fix appveyor segfault from toolchain ABI incompatibilities Feb 29, 2016
@tkelman
Copy link
Contributor Author

tkelman commented Feb 29, 2016

Nevermind, deleting the gcc dll's from the nightly julia binary should work for now to fix appveyor. Not using them may break winrpm packages on nightly but we'll have to see. Better than a segfault on startup.

@pkofod pkofod mentioned this pull request Feb 29, 2016
Merged
tkelman added a commit that referenced this pull request Feb 29, 2016
@tkelman
Merge pull request #15285 from JuliaLang/tk/appveyor
2ac9bc9 
Fix appveyor segfault from toolchain ABI incompatibilities
@tkelman tkelman merged commit 2ac9bc9 into master Feb 29, 2016
@tkelman tkelman deleted the tk/appveyor branch February 29, 2016 11:41
This was referenced Mar 1, 2016
Closed
Merged
tkelman added a commit that referenced this pull request Mar 13, 2016
@tkelman
Do not copy gcc dlls from dist-extras in windows binary-dist
e4bd799 
Use versions from the build system rather than win-extras (which downloads
from opensuse)

Remove gcc dlls from downloaded nightly on appveyor

(cherry picked from commit c1e565c)
ref #15285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkelman @ViralBShah