RFC: Life, the universe, and MAX_TUPLETYPE_LEN #15080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we finally know the question now. |
|
:) |
|
I did a bit more of a serious comparison, checking what packages I had installed on my machine. There were no more test failures than exhibited on master. Is this mergeable? Would anyone prefer a different value? |
|
+1 |
timholy
added a commit
that referenced
this pull request
Feb 20, 2016
RFC: Life, the universe, and MAX_TUPLETYPE_LEN
timholy
added a commit
that referenced
this pull request
May 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent efforts to replace generated functions typically exploit tuples. These methods often work well when the number of arguments is modest, but can run into problems because many approaches involve "inlined splatting," which causes trouble if it creates tuples with more than 8 elements.
I decided to do an experiment bumping MAX_TUPLETYPE_LEN to a value that would not cause problems for algorithms involving AbstractArrays of any reasonable dimensionality. I didn't want to choose
typemax(Int), so I picked the obvious 2-digit integer.My tests have not been thorough, but julia seems to build fine, and the time to run the test suite was no worse (34 minutes on
master, 30 minutes on this PR). Thoughts from those who know the inference/compile toolchain best would be appreciated.