-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove lowercase conversions #10452
remove lowercase conversions #10452
Conversation
not quite done with renaming [ci skip]
What I discovered doing this:
|
@tkelman How do we rebuild pcre_h.jl on windows? |
I guess
On appveyor we grab |
It might not be concise, but perhaps more importantly, it won't work for new number types (#1470 (comment)) |
Looks like everything is passing. I'll merge this very soon. |
remove lowercase conversions
Huzzah! |
🎉 |
Great!
"components" are called "parts" when considering complex numbers, so what about something like |
I would have thought |
|
Good idea. |
I guess the problem with |
Can't |
The barrier to that is that there are many uses that depend on them being un-checked. I guess we could use |
There's also this syntax:
|
I don't think it's a good idea to give very different values for
|
That's a little weird, but maybe ok :-| |
Gotta love the number of deprecation warnings you see after this got merged! |
Fixes #1470 and #6211.