-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method deletion ambiguity recomputation fails for Union #28899
Labels
types and dispatch
Types, subtyping and method dispatch
Comments
timholy
added a commit
that referenced
this issue
Aug 27, 2018
timholy
added a commit
that referenced
this issue
Aug 29, 2018
timholy
added a commit
that referenced
this issue
Aug 29, 2018
timholy
added a commit
that referenced
this issue
Aug 30, 2018
timholy
added a commit
that referenced
this issue
Aug 31, 2018
timholy
added a commit
to timholy/Revise.jl
that referenced
this issue
Sep 5, 2018
This works around JuliaLang/julia#28899 and probably fixes #137 New tests: - test JuliaLang/julia#28899 - test for signature-changes with a gensymmed type - test that changes that do not fundamentally change the type signature do not result in inadvertent deletion (probably #137).
timholy
added a commit
to timholy/Revise.jl
that referenced
this issue
Sep 5, 2018
This works around JuliaLang/julia#28899 and probably fixes #137 New tests: - test JuliaLang/julia#28899 - test for signature-changes with a gensymmed type - test that changes that do not fundamentally change the type signature do not result in inadvertent deletion (probably #137).
vtjnash
pushed a commit
that referenced
this issue
Sep 10, 2018
KristofferC
pushed a commit
that referenced
this issue
Sep 12, 2018
KristofferC
pushed a commit
that referenced
this issue
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#25050 recomputed ambiguities but clearly missed a case:
(It works fine if you delete first and then define the
B
method.)The text was updated successfully, but these errors were encountered: