Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrames hangs when using master commits after #12c51d7... #2607

Closed
milktrader opened this issue Mar 19, 2013 · 7 comments
Closed

DataFrames hangs when using master commits after #12c51d7... #2607

milktrader opened this issue Mar 19, 2013 · 7 comments
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@milktrader
Copy link
Contributor

This was first observed here: JuliaData/DataFrames.jl#216

The problem is somewhere between 12c51d7a8da702b4a25c1774b7bebbd2aae2e21d Rename known-mean variants to stdm and varm. and c3418cb11833480138a5c476568b3eb56ed07ce7 fix #2562

That's a pretty wide range of commits

@kmsquire
Copy link
Member

Just to clarify, c3418cb, mentioned above, is the actual commit which breaks DataFrames. The commit before that (bcfc42d) is fine.

@kmsquire
Copy link
Member

More information:

This DataArray constructor:

https://github.com/HarlanH/DataFrames.jl/blob/master/src/dataarray.jl#L74

seems to be causing julia's inference to get caught in an infinite loop:

julia> d = [1,2,3]
3-element Int64 Array:
 1
 2
 3

julia> m = trues(3)
3-element BitArray:
 true
 true
 true

julia> DataArray(d,m)
^C^CError showing value of type DataArray{Int64,1}:
ERROR: interrupt
 in abstract_eval_call at inference.jl:694
 in abstract_eval at inference.jl:713
 in abstract_eval_arg at inference.jl:665
 in typeinf at inference.jl:1210
 in abstract_call_gf at inference.jl:561
 in abstract_call at inference.jl:638
 in abstract_eval_call at inference.jl:696
 in abstract_eval at inference.jl:713
 in abstract_eval_arg at inference.jl:665
 in typeinf at inference.jl:1210
 in abstract_call_gf at inference.jl:561
 in abstract_call at inference.jl:638
 in abstract_eval_call at inference.jl:696
 in abstract_eval at inference.jl:713
 in abstract_eval_arg at inference.jl:665
 in typeinf at inference.jl:1210

@kmsquire
Copy link
Member

cc: @JeffBezanson

As noted above, this worked before commit c3418cb. The problem could still be with the DataArray constructor definition, but it would still be better not to get into an infinite loop.

@JeffBezanson
Copy link
Member

Ok, that should fix it. Please try it out.

@kmsquire
Copy link
Member

That did it, thanks!

@milktrader
Copy link
Contributor Author

works for me too, using DataFrames 400cb39 before the temp fix commit

@milktrader
Copy link
Contributor Author

This should also close JuliaData/DataFrames.jl#216 and JuliaStats/RDatasets.jl#9

JeffBezanson added a commit that referenced this issue May 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants