-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
643 additions
and
172 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
dc4f179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all very nice, but I'm missing a replacement for
with_handler
(at least in the docs). Is there any plans for this?This is currently breaking the build against nightly on JuliaMath/Interpolations.jl#71
dc4f179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry about that. Hoping to put it back in with deprecation warnings.
Am I correct in observing that you are only using it here: https://github.com/tlycken/Interpolations.jl/blob/7646fe923f4c9e04e23cff2f26222917cbe9b4cb/test/scaling/nointerp.jl ?
It might be easier just to replace that with a try-catch that checks the error message
dc4f179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that's my only usage, so that's feasible for me. And since PkgEval hasn't had any major breakage, I guess I was pretty much the only one using it :P
I did find the helpers handy, though, so I'd much like to see something that fills the same function re-added into this incarnation of
Base.Test
.dc4f179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely planned
dc4f179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍