hack around libgit2 being in Base

JuliaLang · Nov 21, 2017 · 44c7972 · 44c7972
1 parent cec8bca
commit 44c7972
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/base/libgit2/signature.jl b/base/libgit2/signature.jl
@@ -35,10 +35,16 @@ function Base.convert(::Type{GitSignature}, sig::Signature)
     return GitSignature(sig_ptr_ptr[])
 end
 
+# Work around needing to access Dates from Base,
+# even though Dates is in the stdlib.
+# This Ref is filled with the needed function
+# when Dates is loaed
+const unix2datetime = Ref{Any}()
+
 function Base.show(io::IO, sig::Signature)
     print(io, "Name: ", sig.name, ", ")
     print(io, "Email: ", sig.email, ", ")
-    print(io, "Time: ", Dates.unix2datetime(sig.time + 60*sig.time_offset))
+    print(io, "Time: ", unix2datetime[](sig.time + 60*sig.time_offset))
     @printf(io, "%+03i:%02i", divrem(sig.time_offset, 60)...)
 end
 

diff --git a/stdlib/Dates/src/Dates.jl b/stdlib/Dates/src/Dates.jl
@@ -50,6 +50,8 @@ include("io.jl")
 include("parse.jl")
 include("deprecated.jl")
 
+Base.LibGit2.unix2datetime[] = unix2datetime
+
 export Period, DatePeriod, TimePeriod,
        Year, Month, Week, Day, Hour, Minute, Second, Millisecond,
        Microsecond, Nanosecond,