-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix not hardcoding "Project.toml" when fixing up extensions in manifest #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI error in windows seems relevant...
|
Keno
added a commit
to JuliaRegistries/RegistryTools.jl
that referenced
this pull request
Apr 3, 2024
In anticipation of fixing the equivalent of JuliaLang/Pkg.jl#3851 in LocalReigstry.jl.
6 tasks
xref: JuliaLang/julia#54799 |
10 tasks
IanButterworth
force-pushed
the
kc/project_hardcode
branch
from
July 23, 2024 16:27
b09ad40
to
1c2631f
Compare
The fix is JuliaLang/julia#55220 |
Can we fix it on this side as well by calling |
IanButterworth
approved these changes
Jul 23, 2024
5 tasks
IanButterworth
pushed a commit
that referenced
this pull request
Jul 23, 2024
…st (#3851) * fix not hardcoding "Project.toml" when fixing up extensions in manifest file * abspath to be extra safe --------- Co-authored-by: KristofferC <[email protected]> Co-authored-by: Ian Butterworth <[email protected]> (cherry picked from commit 8875120)
IanButterworth
added a commit
that referenced
this pull request
Jul 23, 2024
…st (#3851) * fix not hardcoding "Project.toml" when fixing up extensions in manifest file * abspath to be extra safe --------- Co-authored-by: KristofferC <[email protected]> Co-authored-by: Ian Butterworth <[email protected]>
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3815