Suggest using compat to choose versions of packages
#3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this should be emphasized as "the" way to get the versions you want. Many times folks fight with the resolver to get it to resolve they way they want, when the declarative approach with compat is better. Therefore I think `compat` belongs in the basic starting instructions.
ericphanson
commented
Nov 24, 2023
|
You could add a hint to update to the resolver error message too? |
|
Yeah, that sounds worthwhile, I will try do so |
|
Here is what the hint looks like: julia> Pkg.API.compat(Pkg.Types.Context(), "JSON", "0.21.4")
Compat entry set:
JSON = "0.21.4"
Resolve checking for compliance with the new compat rules...
Error empty intersection between JSON@0.21.1 and project compatibility 0.21.4 - 0.21
Hint Call `update` to attempt to meet the compatibility requirements.I'm using |
|
Test failures seem unrelated Some kind of coverage issue? |
|
Though I'm not sure |
Those are run in the 1.8 env matching the existing docs. But 1.8 won't have the hint. Should we update to 1.11? |
ericphanson
commented
Nov 27, 2023
Yeah. New docs should generally be in latest. (We probably should update all docs to latest before new releases.. but that's a fair bit of work) |
IanButterworth
changed the title
compat to choose versions of packagescompat to choose versions of packages
here it is with "suggestion" btw
|
|
bump |
IanButterworth
approved these changes
Dec 2, 2023
Co-authored-by: Ian Butterworth <[email protected]>
IanButterworth
pushed a commit
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit f7f222f)
7 tasks
KristofferC
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should be emphasized as "the" way to get the versions you want. Many times folks fight with the resolver to get it to resolve they way they want, when the declarative approach with compat is better. Therefore I think
compatbelongs in the basic starting instructions.