-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify rationale for package extension naming #3600
base: master
Are you sure you want to change the base?
Conversation
I think the length of that extension name is actually a reason not to include the parent in the name and perhaps we should make Pkg show the parent and the ext name in the output log, like it does during the precompilation process |
I agree, it would be even better if the extension name would not show up anywhere without its parent. But is that even feasible? |
See #3603 |
The extension naming scheme suggested in the docs, and followed by many packages, leads to unnecessarily verbose output basically everywhere - starting from regular precompilation progress. |
I completely agree. However, as we just saw with this PR, there was yet another case where a pkg extension was shown without reference to its parent. Once somebody with enough knowledge about Pkg.jl is reasonably sure that all such "orphaned" references to pkg extensions have been fixed, this would be a good step though! |
Especially in light of issues such as JuliaLang/julia#50873, where users are faced with warnings such as
it would be very helpful to have both the main package name and the extension trigger package encoded in the extension name (in this example here, it is already done so for
SummationByPartsOperatorsDiffEqCallbacksExt
andLinearMapsStatisticsExt
). This PR adds a sentence to the docs to clarify the rationale for the recommendation to further nudge pkg devs to stick to this convention.