Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Register new package IterTools.jl v0.1.0 #9825

Merged
merged 1 commit into from
Jun 17, 2017

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Jun 15, 2017

Repository: JuliaCollections/IterTools.jl
Release: v0.1.0
Travis: Travis Build Status
cc: @iamed2

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds are up to date.

@iamed2 This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@iamed2
Copy link
Contributor

iamed2 commented Jun 15, 2017

This is the new home for Iterators.jl. Users will be encouraged to move their dependency on Iterators.jl to this package.

@ararslan
Copy link
Member

Perhaps we should make some PRs to dependent packages to ensure everyone gets properly updated. We could even add

function __init__()
    warn("The Iterators.jl package is deprecated in favor of IterTools.jl and Base.Iterators")
end

to Iterators, though I don't know how legit it is to do something like that.

@iamed2
Copy link
Contributor

iamed2 commented Jun 15, 2017

@ararslan I was thinking that would be a good idea. Is there a particular reason why that might not be legit?

@ararslan
Copy link
Member

¯\_(ツ)_/¯ I just don't know

@iamed2
Copy link
Contributor

iamed2 commented Jun 15, 2017

Well, if+when this is accepted, I will do that and start PRs (we'll have to work our way down the dependency graph)

@ararslan
Copy link
Member

Okay, I'd be happy to help divide and conquer.

@tkelman
Copy link
Contributor

tkelman commented Jun 17, 2017

You decided against messing with the history to make renamed versions of all the old tags then?

@ararslan
Copy link
Member

Random idea: Could we upper bound Iterators to 0.6.0, effectively deprecating it in METADATA since it won't be installable on 0.6.0, then people will have to use IterTools instead?

@tkelman
Copy link
Contributor

tkelman commented Jun 17, 2017

That would make everything that's being slow about switching to it also not installable on 0.6, so it's pretty drastic and would be better done after everyone has had a chance to switch.

@ararslan
Copy link
Member

Ah yeah, good call.

@tkelman
Copy link
Contributor

tkelman commented Jun 17, 2017

I'd also avoid making a new 0.4-compatible tag with an init-time warning, since almost all packages have stopped making new releases supporting that julia version. Maybe even make the init-time warning an 0.6-only thing, if some of the packages that depend on Iterators have gone 0.6-only already?

@iamed2
Copy link
Contributor

iamed2 commented Jun 17, 2017

You decided against messing with the history to make renamed versions of all the old tags then?

Yep, since you pointed out that only one package upper-bounds Iterators.

@tkelman tkelman merged commit f340615 into JuliaLang:metadata-v2 Jun 17, 2017
@attobot attobot deleted the IterTools/v0.1.0 branch June 17, 2017 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants