Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1 works around the slow dynamic dispatch that currently exist in Base (JuliaLang/julia#29887). This significantly reduces the overhead of creating the Parser:
Before:
After:
Note that quite a lot of JSON can be parsed within 3μs.
Commit 2, caches the UInt8 vector which is filled with bytes of digits. Reusing the same vector has a bunch of benefits in terms of not having to grow it over and over and the data will be hot.
Using the benchmark
Before:
After:
The third commit doesn't at the moment not have much of a significant performance change but it should be strictly less work for not really more complicated code so why not? :)