Nightlyfix #615
Merged
Nightlyfix #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 85.08% 85.07% -0.01%
==========================================
Files 37 37
Lines 4250 4248 -2
==========================================
- Hits 3616 3614 -2
Misses 634 634 ☔ View full report in Codecov by Sentry. |
vtjnash
reviewed
Nov 22, 2024
| modules = vcat([Main], collect(keys(Base.module_keys))) | ||
| unique!(modules) | ||
| for mod in modules | ||
| for mod in values(Base.loaded_modules) |
There was a problem hiding this comment.
You should preferably use Base.loaded_modules_array, as that has been the stable and safe API for this for many versions (since JuliaLang/julia#23579), while this is neither safe nor stable
There was a problem hiding this comment.
Nice! I didn't know that function existed.
Thanks, I'll switch to that in the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #614