Array(T, dims...) to Array{T}(dims...) (ref JuliaLang/julia#19989) #116
Conversation
| @@ -203,7 +203,7 @@ function jldopen(filename::AbstractString, rd::Bool, wr::Bool, cr::Bool, tr::Boo | |||
| if sz < 512 | |||
| error("File size indicates $filename cannot be a Julia data file") | |||
| end | |||
| magic = Array(UInt8, 512) | |||
| magic = Array{UInt8}(512) | |||
There was a problem hiding this comment.
best to also specify dimensionality Array{UInt8,1} or Vector{UInt8} when known
There was a problem hiding this comment.
Done for the obvious Vector/Matrix cases.
There are still a couple of functions floating around with the argument dims::@compat Tuple{Vararg{Int}}, which I could rewrite as dims::NTuple{N,Int} so that I could use N in the associated array constructors. I held off as I wasn't sure if it was necessary.
| @@ -394,7 +394,7 @@ function read(obj::JldDataset) | |||
| end | |||
| if exists(obj, "dims") | |||
| dims = a_read(obj.plain, "dims") | |||
| return Array(T, dims...) | |||
| return Array{T}(dims...) | |||
| @@ -643,7 +643,7 @@ end | |||
| grefname = name(gref) | |||
| try | |||
| # Write the items to the reference group | |||
| refs = Array(HDF5ReferenceObj, size(data)...) | |||
| refs = Array{HDF5ReferenceObj}(size(data)...) | |||
|
hmm all the tests are failing, what changed? |
|
oh nvm I think I understand why now, will submit patch |
|
whoops, should have checked ci on releases, my mistake for merging. was assuming jrevels wouldn't encourage merging something that wasn't ready yet. thanks in advance for any fixes @musm. |
|
patch included in #117 |
|
My bad, I missed the failure myself. |
I did this with a quick regex, so this should definitely be skimmed before merging
ref JuliaLang/julia#19989