Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting for file vf2.jl and remove ignore in test + autoformatter pass #323

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Dec 21, 2023

PR #190 introduced a BlueStyle formatting check, but back then the file src/Experimental/vf2.jl caused problems to JuliaFormatter. So it was ignored as follows: format(Graphs; ignore=["vf2.jl"]).

Some time later, PR #210 changed this to format(Graphs; ignore="vf2.jl"), which seems to also have ignored a lot of other files. The reasons are a bit unclear to me.

I checked again, and now JuliaFormatter can handle src/Experimental/vf2.jl without erroring. I removed the ignore keyword in the test, and reformatted all the files that had been overlooked since #210.

The only meaningful changes are in test/runtests.jl and src/Experimental/vf2.jl, the rest is just JuliaFormatter doing its thing.

@gdalle gdalle requested a review from aurorarossi December 21, 2023 09:06
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (da6f801) 97.26% compared to head (fb0b95a) 97.26%.

Files Patch % Lines
src/traversals/eulerian.jl 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         115      115           
  Lines        6795     6796    +1     
=======================================
+ Hits         6609     6610    +1     
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle added the enhancement New feature or request label Dec 21, 2023
@gdalle
Copy link
Member Author

gdalle commented Jan 10, 2024

@mcognetta available for a quick review? This is mostly formal

Copy link
Contributor

@mcognetta mcognetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this is entirely a autoformatter review. i would also change the name of the pr to reflect that other files were formatted as well. otherwise lgtm.

test/shortestpaths/astar.jl Show resolved Hide resolved
@gdalle gdalle changed the title Fix formatting for file vf2.jl and remove ignore in test Fix formatting for file vf2.jl and remove ignore in test + autoformatter pass Jan 10, 2024
Copy link
Member Author

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all checked

@gdalle gdalle merged commit 5878e7b into master Jan 10, 2024
8 of 12 checks passed
@gdalle gdalle deleted the gd/more_formatting branch January 10, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants