Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
sincos360
, the rough equivalent ofsincosd
.The
sincos360
is less accurate thansincosd
, but in many cases more accurate thansincos(deg2rad(x))
.Also, while
sincosd(Inf)
throws aDomainError
,sincos360(Inf)
returns(NaN, NaN)
.This is mainly intended to mitigate precompilation and inlining issues. (cf. issue #496)
This might have to be moved to ColorTypes.jl as well as
atan360
. (cf. PR #495) Fortunately, moving those methods to ColorTypes.jl seems to maintain the benefits. However, I'm not sure why the problem occurs withBase
.