-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt documentation from "QuantumCitations" fork #4
Conversation
4549b22
to
1e9f5c5
Compare
I've set |
Please also review the README.md and NEWS.md at https://github.com/JuliaDocs/DocumenterCitations.jl/tree/mg/update-documentation. It seems to me that merging this actually completes re-integrating QuantumCitations back into DocumenterCitations. We should be able to make a release based on this. It might be a good idea to test things out for a few days, though. For example, maybe someone (other than me) with an existing project using DocumenterCitations should try out the new master branch and see if everything works for them. |
Good catch in #5… let me rebase this |
This makes the documentation appropriate for QuantumCitations having been merged back into DocumenterCitations. The default style (following QuantumCitations) has changed to `:numeric`, making this a breaking change. The differences to the previous version of DocumenterCitations are outlined in `NEWS.md`, serving as a guideline for any users switching to the next release of DocumenterCitations, but wanting to keep the existing author-year style citations.
1e9f5c5
to
b0ada9b
Compare
For the record: the easiest way to review the rendered documentation locally is to run
|
From #3, I think the only API thing that needs to be discussed is the return value of |
At least post-1.0, I would prefer not to consider it (or anything detailed in Internals) part of the public API. And I agree, we can probably adapt to the next Documenter version without making any breaking changes.
Returning a markdown string that then gets parsed and inserted into the output tree is exactly the behavior I would like, see #6 |
I don't have any strong opinions here, and nothing stood out when I skimmed through the PR 🙂 The only suggestion I would have is to adopt the keep a changelog format for the changelog/ |
Sounds good to me! I've changed the format of |
This makes the documentation appropriate for QuantumCitations having been merged back into DocumenterCitations.
The default style (following QuantumCitations) has changed to
:numeric
, making this a breaking change. The differences to the previous version of DocumenterCitations are outlined inNEWS.md
, serving as a guideline for any users switching to the next release of DocumenterCitations, but wanting to keep the existing author-year style citations.