HTMLWriter: allow extra attributes for external asset links, default to no-referrer policy #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exaexa
changed the title
mortenpi
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Something I noticed: we load most of our JS dependencies via requirejs, and so those are not covered by these changes. So the CDN will still know what site is making the requests. I wonder if using the <meta name="referer"> tag would be the more appropriate solution?
|
|
||
| HTMLContext(doc, settings=nothing) = new( | ||
| doc, settings, [], "", "", "", [], "", | ||
| Documenter.NavNode("search", "Search", nothing), | ||
| AtExampleFallbackWarning[], | ||
| [:referrerpolicy => "no-referrer"] |
There was a problem hiding this comment.
Just thinking out loud, but I wonder if it should/could be strict-origin. But I'm also not sure it would really make a difference.
| @@ -619,11 +619,13 @@ mutable struct HTMLContext | |||
| search_index_js :: String | |||
| search_navnode :: Documenter.NavNode | |||
| atexample_warnings::Vector{AtExampleFallbackWarning} | |||
| external_link_attribs :: Vector{Pair{Symbol,String}} | |||
There was a problem hiding this comment.
Not very important, but in principle, the fields of this struct are meant for mutable state. I think I'd make this a global const for now.
And just a small nitpick:
Suggested change
| external_link_attribs :: Vector{Pair{Symbol,String}} | |
| external_link_attributes :: Vector{Pair{Symbol,String}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #2391. cc @mortenpi
( I don't expect this code to stay for very long, but it's a simple fix that may hold for at least as long as the #2159 isn't fixed. )