-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the test suite segfaults on master #227
Comments
Seems to be caused by JuliaLang/julia#42172. I will take a look |
Ah, I was wrong. The segfaults are actually nondeterministic, so I was able to observe this on JuliaLang/julia@2f47dae (1.8.0-DEV.527) as well. |
This is really weird... I can reproduce this on 1.7, just not with the official 1.7-beta3 build (also built exactly the same commit myself and got the segfault). I also deleted The source of the error seems to be that the datatype of the argument |
Somehow this diff works for me... diff --git a/test/irshow.jl b/test/irshow.jl
index 55a493c..54c1a84 100644
--- a/test/irshow.jl
+++ b/test/irshow.jl
@@ -2,7 +2,8 @@ using Cthulhu, Test, DeepDiffs
include("utils.jl")
-foo = Core.eval(Module(), Meta.parseall(raw"""
+m = Module()
+Core.eval(m, Meta.parseall(raw"""
function foo(x, y)
z = x + y
if z < 4
@@ -18,7 +19,7 @@ end
tf = (true, false)
@testset "optimize: $optimize" for optimize in tf
- _, src, infos, mi, rt, slottypes = process(foo, (Int, Int); optimize);
+ _, src, infos, mi, rt, slottypes = process(m.foo, (Int, Int); optimize);
@testset "debuginfo: $debuginfo" for debuginfo in instances(Cthulhu.DInfo.DebugInfo)
@testset "iswarn: $iswarn" for iswarn in tf |
It successfully ran 12h ago (
Julia Version 1.8.0-DEV.527
https://github.com/JuliaDebug/Cthulhu.jl/runs/3603151848), but with the latest master (Version 1.8.0-DEV.542
) it yields the following error:It seems that
PerformanceTestTools.@include("irshow.jl")
causes this error, and certainly we can get the same error by running the script directly:The text was updated successfully, but these errors were encountered: