Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter docs, Fixes #3460 #3461

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Update filter docs, Fixes #3460 #3461

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a20927
Update filter docs
sprig Sep 3, 2024
dd392ff
Apply suggestions from code review
bkamins Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/abstractdataframe/abstractdataframe.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,6 +1151,10 @@ data frames.
function instead as it is consistent with other DataFrames.jl functions
(as opposed to `filter`).

!!! note
bkamins marked this conversation as resolved.
Show resolved Hide resolved
Due to type stability the `filter(cols => fun, df::AbstractDataFrame; view::Bool=false)`
call is preferred in performance critical applications.

$METADATA_FIXED

See also: [`filter!`](@ref)
Expand Down Expand Up @@ -1281,6 +1285,10 @@ data frames.
function instead as it is consistent with other DataFrames.jl functions
(as opposed to `filter!`).

!!! note
bkamins marked this conversation as resolved.
Show resolved Hide resolved
Due to type stability the `filter!(cols => fun, df::AbstractDataFrame)`
call is preferred in performance critical applications.

$METADATA_FIXED

See also: [`filter`](@ref)
Expand Down
Loading