Rename filter types to distinguish coefficients from implementations #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonster
force-pushed
the
sjk/rename-filters
branch
from
68218a3 to
305a786
Compare
|
Or should we do TFFilter -> PolynomialTF or PolynomialRatio? |
|
+1 for something like PolynomialRatio
|
ZPKFilter -> ZeroPoleGain TFFilter -> PolynomialRatio BiquadFilter -> Biquad SOSFilter -> SecondOrderSections
simonster
force-pushed
the
sjk/rename-filters
branch
from
305a786 to
c1da1b2
Compare
|
Changes Unknown when pulling c1da1b2 on sjk/rename-filters into * on master*. |
simonster
added a commit
that referenced
this pull request
Apr 6, 2015
Rename filter types to distinguish coefficients from implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my comment here
ZPKFilter -> ZeroPoleGain
TFFilter -> TransferFunction
BiquadFilter -> Biquad
SOSFilter -> SecondOrderSections