Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused about docs #885

Open
oxinabox opened this issue Dec 18, 2023 · 3 comments
Open

Confused about docs #885

oxinabox opened this issue Dec 18, 2023 · 3 comments

Comments

@oxinabox
Copy link
Member

oxinabox commented Dec 18, 2023

Eh, I'm finding it very hard to work out what methods are implemented for what in what release thanks to all this churn.

Pkg finds the current release at 0.18.15 for me, which uses dequeue! for PriorityQueue and does not implement popfirst! - at least, I am shouted at for trying to use it.

The documentation, however, merrily tells me that I should definitely use popfirst! , despite (again), this not being implemented in the release that Pkg thinks is most recent.

If this isn't implemented in an actually released version, can the documentation at least not claim this works when it doesn't yet?

Originally posted by @aoanla in #845 (comment)

@oxinabox
Copy link
Member Author

The stable docs don't seem to mention popfirst! at all: https://juliacollections.github.io/DataStructures.jl/stable/search/?q=popfirst%21

The dev docs do: https://juliacollections.github.io/DataStructures.jl/dev/search/?q=popfirst%21

The very purpose of the dev docs is to be the docs for the currently in dev (i.e. not released) version of the package.

You can change which version of the docs you are looking at with the menu selector one the side:
(Which moves between versions of the docs as on the dev version we have been)
screenshot of the dev docs
screenshot of the stable docs

There is hardly any churn, this package is very slow moving, and hasn't released breaking changes in years.
These changes are needful to get us to 1.0, where we are consistent with the names of all the functions in Base (#479).
Which is taking a long time, due to limited time people have to work on this.

@aoanla
Copy link

aoanla commented Dec 18, 2023 via email

@oxinabox
Copy link
Member Author

That's a good suggestion.
I have opened a issue on Documenter.jl to see if we can get that feature added.
JuliaDocs/Documenter.jl#2382

We also should run the script linked in JuliaDocs/Documenter.jl#1577
to make sure our outdated docs have the outdated banner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants