-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoCredentials class for accessing publicly available data #50
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #50 +/- ##
===========================================
+ Coverage 8.92% 20.75% +11.82%
===========================================
Files 11 11
Lines 448 453 +5
===========================================
+ Hits 40 94 +54
+ Misses 408 359 -49
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@mattBrzezinski I have rebased this. The point is that we can now easily write tests without credentials, so here we should already be able to increase a bit test coverage. |
@mattBrzezinski before I merge this, I'm not sure how to do versioning. Is it OK if we leave the current number at master for a while before we add other new features and then later tag a new version? |
Yeah you can do that, you don't need to tag everything you release. Just that when you do pick the appropriate SemVer bump for the changes. |
NoCredentials
simply omits the "Authorization" header, and works with publicly available data. Something similar is actually offered in the C++ GCP API.