Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoCredentials class for accessing publicly available data #50

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

nlw0
Copy link
Collaborator

@nlw0 nlw0 commented Jul 24, 2022

NoCredentials simply omits the "Authorization" header, and works with publicly available data. Something similar is actually offered in the C++ GCP API.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #50 (7298551) into master (adef89e) will increase coverage by 11.82%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master      #50       +/-   ##
===========================================
+ Coverage    8.92%   20.75%   +11.82%     
===========================================
  Files          11       11               
  Lines         448      453        +5     
===========================================
+ Hits           40       94       +54     
+ Misses        408      359       -49     
Impacted Files Coverage Δ
src/GoogleCloud.jl 100.00% <ø> (ø)
src/credentials.jl 2.50% <ø> (+2.50%) ⬆️
src/api/api.jl 55.31% <100.00%> (+33.01%) ⬆️
src/session.jl 7.81% <100.00%> (+7.81%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nlw0 nlw0 force-pushed the nic/nocredentials branch from 4245143 to 5fd90dd Compare June 6, 2023 20:53
@nlw0
Copy link
Collaborator Author

nlw0 commented Jun 6, 2023

@mattBrzezinski I have rebased this. The point is that we can now easily write tests without credentials, so here we should already be able to increase a bit test coverage.

@nlw0
Copy link
Collaborator Author

nlw0 commented Jun 8, 2023

@mattBrzezinski before I merge this, I'm not sure how to do versioning. Is it OK if we leave the current number at master for a while before we add other new features and then later tag a new version?

@nlw0 nlw0 closed this Jun 8, 2023
@nlw0 nlw0 reopened this Jun 8, 2023
@mattBrzezinski
Copy link
Member

@mattBrzezinski before I merge this, I'm not sure how to do versioning. Is it OK if we leave the current number at master for a while before we add other new features and then later tag a new version?

Yeah you can do that, you don't need to tag everything you release. Just that when you do pick the appropriate SemVer bump for the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants