Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Julia v0.7 #136

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

kmsquire
Copy link
Contributor

@kmsquire kmsquire commented Sep 2, 2017

  • Parsing seems to have changed slightly in Julia (or JuliaParser?) between v0.6 and v0.7.
    For test/data/testparser.jl, line 10 is the end of a @doc string (""" ->), and Line 11
    is an expression (f6(x) = 6x)
  • In v0.6, the zero count goes to line 10, and in v0.7, the zero count goes (more correctly?)
    to line 11

@codecov-io
Copy link

codecov-io commented Sep 2, 2017

Codecov Report

Merging #136 into master will decrease coverage by 20.98%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #136       +/-   ##
===========================================
- Coverage   73.02%   52.04%   -20.99%     
===========================================
  Files           6        6               
  Lines         241      342      +101     
===========================================
+ Hits          176      178        +2     
- Misses         65      164       +99
Impacted Files Coverage Δ
src/codecovio.jl 64.38% <0%> (-29.62%) ⬇️
src/Coverage.jl 62.59% <0%> (-24.64%) ⬇️
src/lcov.jl 65.21% <0%> (-23.02%) ⬇️
src/parser.jl 61.29% <0%> (-19.67%) ⬇️
src/memalloc.jl 42.85% <0%> (-14.84%) ⬇️
src/coveralls.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45798c...000e914. Read the comment docs.

test/runtests.jl Outdated
# In v0.6, the zero count goes to line 10, and in v0.7, the zero count goes (more correctly?)
# to line 11

if VERSION < v"0.7.0-"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea more specifically what caused the change? looks like it happened between 2 and 3 months ago, judging by travis logs - https://travis-ci.org/JuliaCI/Coverage.jl/builds/234799535 vs https://travis-ci.org/JuliaCI/Coverage.jl/builds/248594841

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to test or do a proper git bisect right now, but https://github.com/JuliaLang/julia/pull/21746/commits is one possiblilty.

Copy link
Contributor Author

@kmsquire kmsquire Sep 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm somewhat doubtful, so we'll probably need to do a git bisect to find out the true cause.

My real interest here is to attempt to discover why coverage is dropping significantly for most projects (such as the codecov/project below--see #132). I'm not even sure this is related, so might want to do a git bisect for this as well, if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running git bisect now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git bisect says the culprit is "various improvements to parser #22161", which makes much more sense than my initial guess.

I've updated the pull request to reference this specific commit. Not sure right now if it has anything to do with #132, although it's probably worth testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump

* JuliaLang/julia#22161 updated the parser and
  caused some changes in how Coverage works
* For test/data/testparser.jl, line 10 is the end of a @doc string (`"""
  ->`), and Line 11 is an expression (`f6(x) = 6x`)
* Before the above commit, the zero count goes to line 10, and after,
  the zero count goes (more correctly?) to line 11
@kmsquire kmsquire force-pushed the kms/fix_v0.7_coverage_bug branch from 7fce1b9 to 000e914 Compare September 5, 2017 04:42
@tkelman tkelman merged commit bb8199e into JuliaCI:master Sep 8, 2017
@ararslan ararslan mentioned this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants