-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add simple allocation benchmarks #291
Conversation
Can we add a |
here's a gist of the results, running on JuliaLang/julia#43868 vs master. Shows no regressions https://gist.github.com/vilterp/2444a133822427238e46eb23f5b60925 (though honestly running on my laptop is not consistent) |
Moved some work to inner loops to offset the impact of calling |
via BenchmarkTools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Thanks for setting it up! :) 👍 👍
Excellent, thanks! |
cc @vchuravy @NHDaly
A simple-as-possible benchmark to help us see the impact of JuliaLang/julia#42768, JuliaLang/julia#43868 etc.
Was also thinking of using
@timed
and asserting againstgc_stats.poolalloc
to make sure we're actually measuring pool allocations.Here it is running on JuliaLang/julia#43868: