Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for ==, isequal, any and all #138

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

nalimilan
Copy link
Collaborator

Good to have in general, but particularly needed before adapting these functions to support three-valued logic with missing values.

@nalimilan nalimilan changed the title Add benchmarks ==, isequal, any and all Add benchmarks for ==, isequal, any and all Nov 19, 2017
@ararslan ararslan requested a review from stevengj November 19, 2017 22:14
@nalimilan
Copy link
Collaborator Author

Bump! (This is blocking JuliaLang/julia#24653.)

@ararslan
Copy link
Member

It looks okay to me. Nanosoldier is having some currently undiagnosed issues at the moment so benchmarking won't be available right away once this is merged and tuned, just FYI.

@ararslan ararslan merged commit dfd20c4 into JuliaCI:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants