Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace IS_CI with is_ci() #246

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Replace IS_CI with is_ci() #246

merged 3 commits into from
Nov 9, 2021

Conversation

findmyway
Copy link
Member

@findmyway findmyway commented Nov 9, 2021 •
edited by rikhuijzer
Loading

Close #245.

@rikhuijzer rikhuijzer mentioned this pull request Nov 9, 2021
Closed
@rikhuijzer rikhuijzer closed this Nov 9, 2021
@rikhuijzer rikhuijzer reopened this Nov 9, 2021
@rikhuijzer
Copy link
Collaborator

Actually, you're probably right. It doesn't gain much in terms of speed but loses a lot of flexibility.

@rikhuijzer rikhuijzer enabled auto-merge (squash) November 9, 2021 08:30
@rikhuijzer rikhuijzer merged commit 5460866 into JuliaBooks:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always use is_ci() instead of IS_CI?
2 participants
@findmyway @rikhuijzer