Do not fix link when the uri contains a schema #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the formatting is wrong somehow. I'll revert it soon. |
|
It seems that you're again fixing an issue. Thank you for that :). However, could you also explain a bit in words what you've added and why it is necessary? I don't understand the goal of this pull request yet. |
findmyway
commented
May 4, 2021
| @@ -73,6 +74,7 @@ | |||
| <link rel="stylesheet" href="/Books.jl/files/style.css"/> | |||
| <a href="/Books.jl/test.html#sec:foo">Foo</a> | |||
| <h2 data-number="3.5" id="sec:foo"><span class="header-section-number">3.5</span> Foo</h2> | |||
| <p> <a href="https://www.google.com">Jump</a></p> | |||
There was a problem hiding this comment.
This line will become the following line without this PR:
<a href="/Books.jlhttps://www.google.com">Jump</a></p>
There was a problem hiding this comment.
Now I get it! Good addition and nice that you've added a test too 😄 💯
findmyway
commented
May 4, 2021
|
Thanks for the clarification. 👍 I'll take a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.