-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate this package in favor of package extensions? #15
Comments
I think this makes sense. I will add a note to readme of |
This seems like a false dilemma, as it's currently possible to use StaticArraysCore as a weak dependency from a package extension. And it seems to me that this is actually the best of both worlds? I'm currently creating a new package for sorting tuples, and I realized that it would make a lot of sense to add a package extension to support static vectors (in addition to tuples). Should I have a weakdep on StaticArrays or on StaticArraysCore? |
I think benefits of using |
It's actually much worse than this. The split in functionality makes it impossible to implement a StaticArrays extension correctly (since the extension needs to be on the |
What's the issue with 3rd party generated functions? I would expect that correctly implemented generated functions should work fine. |
The example is the intersection of JuliaArrays/ArrayInterface.jl#449 with this method for https://github.com/SciML/RecursiveArrayTools.jl/blob/e0f1b1ddc98671ade78fb4fd89339224e145fb95/src/array_partition.jl#L121 |
Well, as far as I can tell that should not be a generated function but rather a normal one and rely on constant propagation and Julia's compile-time execution. |
that probably is true. however the separation still has other costs (since it makes most of the operations in StaticArrays into type piracy) |
Anyway, I'm fairly indifferent regarding removal of StaticArraysCore as long as I'm not the one handling all the issues it would cause. |
Julia 1.10 have support for "package extensions" (https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)). Instead of packages using
StaticArraysCore
as a "hard" dependency, which is always loaded, it seem better to recommend usingStaticArrays
directly as a weak dependency.The text was updated successfully, but these errors were encountered: