-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement boundary asymptotics #131
Conversation
…fail by a digit without higher order terms)
I think this is a good solution for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not looked into math details yet. I added some minor comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 96.62% 96.89% +0.26%
==========================================
Files 9 9
Lines 1244 1384 +140
==========================================
+ Hits 1202 1341 +139
- Misses 42 43 +1 ☔ View full report in Codecov by Sentry. |
This is certainly MATLAB-style code, but so is most of this package.... I think trying to de-matlab the code at this point is a fools-errand. If the tests pass we should just merge and someone can improve the style/using |
Sounds good. I made some of the small changes that @hyrodium suggested, and added a test to cover a few previously untested lines of the |
Could you please add more tests for the coverage? |
I've satisfied all the code coverage checks. Let me know if there's anything else I can do to get things finalized. |
I'll merge if no one objects in the next day |
This is a great addition! It should be merged ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you bump the version to v1.0.1
?
I've translated the MATLAB routine$N$ and $\alpha, \beta < -0.5$ .
feval_asy2
inchebfun/jacpts.m
which implements the boundary asymptotics from Hale and Townsend 2012. These asymptotics are necessary to get high accuracy Gauss-Jacobi weights, particularly for largeI've included tests which verify that issues #58 and #130 are both resolved by these changes.
This implementation relies on storing$10 \times 10$ Chebyshev differentiation and integration matrices to numerically evaluate the higher order coefficients in the relevant asymptotics. Personally I think this is a mild price to pay, and avoids reliance on other packages. However, @dlfivefifty suggested that creating a core
ChebyshevTransforms.jl
package to be used also by other interfaces may be a more elegant solution.