Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required versions of Julia from 1.0 to 1.6 #113

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

hyrodium
Copy link
Collaborator

No description provided.

@hyrodium hyrodium changed the title Update reqired versions of Julia from 1.0 to 1.6 Update required versions of Julia from 1.0 to 1.6 Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 96.65% // Head: 96.65% // No change to project coverage 👍

Coverage data is based on head (6adf8f8) compared to base (7741f09).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files           8        8           
  Lines        1224     1224           
=======================================
  Hits         1183     1183           
  Misses         41       41           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlfivefifty
Copy link
Member

Should be a minor version bump. Is there a specific reason to drop support?

@hyrodium
Copy link
Collaborator Author

Is there a specific reason to drop support?

#112 uses evalpoly which requires at least Julia 1.4.

Should be a minor version bump.

I think it's okay to wait for #112.

@heltonmc
Copy link
Contributor

heltonmc commented Oct 10, 2022

Yes, sorry. I think also see JuliaLang/julia#33289 and linked PR.

The current code base has some usage of @evalpoly which will be deprecated in the future (though not imminent). But I think it might be best to update the code base to use the function going forward as the macro just lowers to call the function. But I’m happy to change the PR to use the macro as well.

@dlfivefifty dlfivefifty merged commit a744406 into JuliaApproximation:master Oct 11, 2022
@ranocha
Copy link

ranocha commented Nov 2, 2022

Did I get it right that this is the only "breaking" change in FastGaussQuadrature.jl v0.5? So basically, as a downstream dependency, I do not have to do anything and can just update my package bounds?

@hyrodium
Copy link
Collaborator Author

hyrodium commented Nov 2, 2022

Sorry for the confusion. Yes, this PR is the only reason for the v0.5.0 release. I think it was better to release v0.4.10 instead of v0.5.0 because this PR does not include breaking changes. The only benefit of releasing v0.5.0 is that we can maintain this package for Julia v1.0 in FastGaussQuadrature.jl v0.4.x, but Julia v1.0.x is no longer maintained and we do not want to maintain for that.

@dlfivefifty Do you have any thoughts on this?

@ranocha
Copy link

ranocha commented Nov 2, 2022

Thanks! Well, v0.5 has already been released, that's why I noticed this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants