Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth using environment variables #56

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Auth using environment variables #56

wants to merge 3 commits into from

Conversation

characat0
Copy link

This PR modifies the default constructor to read environment variables MLFLOW_TRACKING_USERNAME and MLFLOW_TRACKING_PASSWORD for credentials and creates the Authorization header using basic auth.

@pebeto pebeto self-requested a review October 23, 2024 18:59
@pebeto pebeto added the enhancement New feature or request label Oct 23, 2024
pebeto
pebeto requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@pebeto pebeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests are required for almost every PR. Don't forget to add the new env variables here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pebeto pebeto pebeto requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@characat0 @pebeto