feat: infer base from package json scripts during migration #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested changes
Oct 30, 2023
JoshuaKGoldberg
added
the
status: waiting for author
Codecov Report
@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 93.61% 93.58% -0.03%
==========================================
Files 92 93 +1
Lines 4952 4992 +40
Branches 413 420 +7
==========================================
+ Hits 4636 4672 +36
- Misses 315 318 +3
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
removed
the
status: waiting for author
JoshuaKGoldberg
approved these changes
Oct 31, 2023
| @@ -111,6 +111,11 @@ vi.mock("./createOptionDefaults/index.js", () => ({ | |||
| }, | |||
| })); | |||
|
|
|||
| const readPackageData = vi.hoisted(() => vi.fn()); | |||
There was a problem hiding this comment.
TIL about vi.hoisted, very nice! https://vitest.dev/api/vi.html#vi-hoisted
Elsewhere in this repo I've used mock* as a naming convention. I think both are valid and reasonable... but the mock* is used everywhere else, so I'll go ahead and make the change.
|
🎉 This is included in version v1.42.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Add a naive solution for checking the existing
package.jsonduring migration to infer the base.🐸