Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack 5 support #365

Closed
wants to merge 1 commit into from
Closed

Conversation

orlov-vo
Copy link

What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
feature

What is the current behavior? (You can also link to an open issue here)
Now it doesn't work with Webpack 5

What is the new behavior (if this is a feature change)?
It should work with Webpack 5

Does this PR introduce a breaking change?
no

Please check if the PR fulfills contributing guidelines
ok

It's is related with #359

@orlov-vo
Copy link
Author

It seems like webpack-toolkit isn't compatible with webpack 5

$ yarn test:webpack-5
...
internal/modules/cjs/loader.js:626
    throw err;
    ^

Error: Cannot find module 'webpack/lib//MultiEntryPlugin'
Require stack:
- E:\projects\svg-sprite-loader\node_modules\webpack-toolkit\lib\addEntry.js
- E:\projects\svg-sprite-loader\node_modules\webpack-toolkit\index.js
- E:\projects\svg-sprite-loader\test\utils\create-compiler.js
- E:\projects\svg-sprite-loader\test\utils\index.js
- E:\projects\svg-sprite-loader\test\loader.test.js
- E:\projects\svg-sprite-loader\node_modules\mocha\lib\mocha.js
- E:\projects\svg-sprite-loader\node_modules\mocha\index.js
- E:\projects\svg-sprite-loader\node_modules\mocha\bin\_mocha

@sghoweri
Copy link

Any updates on this? Is Webpack v5 support planned / expected?

@zhongzhong0505
Copy link

zhongzhong0505 commented Nov 30, 2020

Any updates on this?

@netconomy-stephan-dum
Copy link

please close this PR to avoid confusion as its already solved by:
#403

@d3x42 d3x42 closed this Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants