-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set the JVM target #594
base: master
Are you sure you want to change the base?
Conversation
This is meant to fix #579 |
Hi, @sheu. Nice fix, thank you! You're right :) Could you please add a test please? |
@sheu hi, any updates? :) |
I had a hard time figuring out how best to test it. I will push the testcase today. |
d6bc1ca
to
c41e10d
Compare
c41e10d
to
1d29913
Compare
Finally added the test case but that meant that I had to change my solution to make it testable. |
Hmm, maybe we can just put some code and run it? like @Test
fun `jvm target 11 test`() {
run(
code = "fun main() {\n // put some code here \n}",
contains = "the result of the code"
)
}
|
@sheu hi, let's take your first version to the master? |
Why do you don't set-up the jvmtoolchain using |
No description provided.