-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning on missing alias #71
Conversation
I believe people will hate the tool if you throw warnings where there are no conflicts. It would be healthier to error out if two columns clash like select a.someName, b.someName .... that is definitely an error |
@nicoabie 🤷♂️ that's kind of already happening from the DB level already
You would get clashing column names I'm still leaning towards throwing warning and then in V1, make it throw an error but have a configuration to warn only if the user wants. But you have a good point. I will handle the clashing name problem next |
Correct, that sql should rise an error whereas the example you posted that raises a warning should be ok. Do you see the difference? The only way of really help them is rising an error when columns clash |
Feature:
You would get this if you have a query that's like
TODO