Fix import of assignments without due dates (#251) #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNZL
added a commit
that referenced
this pull request
Jul 4, 2024
JamesNZL
added a commit
that referenced
this pull request
Jul 4, 2024
… (#387) * Fix import of assignments without due dates (#251) (#384) * fix(canvas): 🐛 do not store absence of due date as unix epoch (#251) * fix(import): 🐛 correctly import assignments without due dates to notion (#251) * refactor(types): 🏷️ refactor type declaration files change to regular typescript files * fix(validator): 🐛 fix timezone validation (#252) * build(notion): 👽 pin notion api version * feat(notion): ✨ parse notion page properties * feat(options): ✨ add `notion.importChanges` options * fix(interface): 💄 properly hide segmented controls * refactor(types): 🧑💻 strongly type `Storage` key methods * docs(readme): 📝 update `readme` * docs(readme): 📝 update advanced options heading size * feat(import)!: ✨ update existing pages if assignment has changed (#385) BREAKING CHANGE: This requires a new previously unheld capability on the integration. Existing users must reauthorise with Notion. * build(actions): 💚 fix gulp build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251, where assignments without due dates were incorrectly ignored on import.